Add support for test methods #6
Conversation
|
@nicoddemus or @Tinche: Is should be possible to configure @coveralls to don't have a comment message each time? coveralls is already present in the check list, with Travis-CI. |
- Inspired on the default implementation for pytest_pyfunc_call for normal test functions - Refactor pytest_pyfunc_call to remove duplication fixes #5
1 similar comment
|
@GMLudo I'm not sure... I also find them a little annoying to be honest, but they are useful. Just updated the PR fixing the missing coverage lines. On thing I thought strange was that the missing coverage lines were almost the entire I just commented that function out locally and the tests still pass... 😳 |
|
@nicoddemus, yes it's really useful, like Travis-CI, nevertheless, at least to me, the checks in pull requests is less annoying that a new comment. |
|
@nicoddemus Looks great to me! Thanks for dealing with this so quickly. As for branches/repos, just do what you feel most comfortable with. @GMLudo I've disabled coveralls comments in pull requests. I have to admit I wasn't even aware of the 'Show all checks' thingy until now, pretty nifty! |
Some facilities for AsyncQueryResult
fixes #5
(BTW @Tinche, hope you don't mind me creating a branch in this repository instead of on a fork... let me know if you prefer the latter).